belliottsmith commented on PR #1891: URL: https://github.com/apache/cassandra/pull/1891#issuecomment-1451610408
> The exception to this are trivial suggestions that are addressed exactly as suggested, such adding an @Override annotation, fixing typos, and that kind of nits. IMO those conversations are unlikely to be discussed by the reviewer and thus they can be immediately resolved. I know that some reviewers prefer to handle closing even these, as it is very easy for an author to make mistakes when closing them. I have been on both ends of this - having failed to handle something I thought I had handled and had closed, and having had resolved something that wasn't. So it can be helpful to have a blanket policy of leaving it to the reviewer, and trying to have close rounds of review. But, I agree this isn't _so_ important. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
