bdeggleston commented on code in PR #33:
URL: https://github.com/apache/cassandra-accord/pull/33#discussion_r1123529719
##########
accord-core/src/main/java/accord/utils/DeterministicIdentitySet.java:
##########
@@ -117,6 +121,12 @@ public boolean add(T item)
entry.next.prev = entry;
return true;
}
+ // we add to the front, and iterate in reverse order, so that we can add
and remove while iterating without modifying the set we iterate over
+ @Override
+ public boolean add(T item)
Review Comment:
`add` throws an `UnsupportedOperationException` in `Listeners.Immutable`, so
`addInternal` is used when making immutable copies. See the copy constructor in
this class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
