bereng commented on code in PR #1891:
URL: https://github.com/apache/cassandra/pull/1891#discussion_r1127940030
##########
test/unit/org/apache/cassandra/io/sstable/LegacySSTableTest.java:
##########
@@ -637,18 +637,18 @@ public void testGenerateSstables() throws Throwable
File ksDir = new File(LEGACY_SSTABLE_ROOT,
String.format("%s/legacy_tables", BigFormat.latestVersion));
ksDir.tryCreateDirectories();
- copySstablesFromTestData(String.format("legacy_%s_simple",
BigFormat.latestVersion), ksDir);
- copySstablesFromTestData(String.format("legacy_%s_simple_counter",
BigFormat.latestVersion), ksDir);
- copySstablesFromTestData(String.format("legacy_%s_clust",
BigFormat.latestVersion), ksDir);
- copySstablesFromTestData(String.format("legacy_%s_clust_counter",
BigFormat.latestVersion), ksDir);
+ copySstablesFromTestData(String.format("legacy_%s_simple",
BigFormat.latestVersion), ksDir, "legacy_tables");
+ copySstablesFromTestData(String.format("legacy_%s_simple_counter",
BigFormat.latestVersion), ksDir, "legacy_tables");
+ copySstablesFromTestData(String.format("legacy_%s_clust",
BigFormat.latestVersion), ksDir, "legacy_tables");
+ copySstablesFromTestData(String.format("legacy_%s_clust_counter",
BigFormat.latestVersion), ksDir, "legacy_tables");
}
- public static void copySstablesFromTestData(String table, File ksDir)
throws IOException
+ public static void copySstablesFromTestData(String table, File ksDir,
String ks) throws IOException
Review Comment:
I think that's all. It was my idea to provide that code you can uncomment
ready for the next dev that might need it. Everything else needed I baked
seamlessly into the existing code already, such as having KS as a param here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
