smiklosovic commented on code in PR #2117: URL: https://github.com/apache/cassandra/pull/2117#discussion_r1127977665
########## test/unit/org/apache/cassandra/db/virtual/SnapshotsTableTest.java: ########## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.db.virtual; + +import java.time.Instant; + +import com.google.common.collect.ImmutableList; +import org.junit.After; +import org.junit.Before; +import org.junit.BeforeClass; +import org.junit.Test; + +import org.apache.cassandra.config.DurationSpec; +import org.apache.cassandra.cql3.CQLTester; +import org.apache.cassandra.cql3.UntypedResultSet; + +public class SnapshotsTableTest extends CQLTester +{ + private static final String KS_NAME = "vts"; + private final String SNAPSHOT_TTL = "snapshotTtl"; + private final String SNAPSHOT_NO_TTL = "snapshotNoTtl"; + private final String SNAPSHOT_EPHEMERAL = "snapshotEphemeral"; + private final DurationSpec.IntSecondsBound ttl = new DurationSpec.IntSecondsBound ("4h"); + + @BeforeClass + public static void setUpClass() + { + CQLTester.setUpClass(); + } + + @Before + public void before() throws Throwable + { + SnapshotsTable table = new SnapshotsTable(KS_NAME); + VirtualKeyspaceRegistry.instance.register(new VirtualKeyspace(KS_NAME, ImmutableList.of(table))); + + createTable("CREATE TABLE %s (pk int, ck int, PRIMARY KEY (pk, ck))"); + for (int i = 0; i != 10; ++i) + { + execute("INSERT INTO %s (pk, ck) VALUES (?, ?)", i, i); + } + flush(); + } + + @After + public void after() + { + clearSnapshot(SNAPSHOT_NO_TTL, currentKeyspace()); + clearSnapshot(SNAPSHOT_TTL, currentKeyspace()); + clearSnapshot(SNAPSHOT_EPHEMERAL, currentKeyspace()); + dropTable("DROP TABLE %s"); + } + + @Test + public void testSnapshots() throws Throwable + { + Instant createTime = Instant.now(); + String createTimeStr = createTime.toString(); + snapshot(SNAPSHOT_NO_TTL, createTime); + snapshot(SNAPSHOT_TTL, ttl, createTime); + snapshot(SNAPSHOT_EPHEMERAL, true, null, createTime); + + // query all from snapshots virtual table + UntypedResultSet result = execute("SELECT id, keyspace_name, table_name, created_at, expires_at, ephemeral FROM vts.snapshots"); + assertRows(result, + row(SNAPSHOT_EPHEMERAL, CQLTester.KEYSPACE, currentTable(), createTimeStr, null, true), + row(SNAPSHOT_NO_TTL, CQLTester.KEYSPACE, currentTable(), createTimeStr, null, false), + row(SNAPSHOT_TTL, CQLTester.KEYSPACE, currentTable(), createTimeStr, createTime.plusSeconds(ttl.toSeconds()).toString(), false)); + + // query with conditions + result = execute("SELECT id, keyspace_name, table_name, created_at, expires_at, ephemeral FROM vts.snapshots where ephemeral = true allow filtering"); Review Comment: `allow filtering` is not necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
