smiklosovic commented on code in PR #2117:
URL: https://github.com/apache/cassandra/pull/2117#discussion_r1127983106
##########
test/unit/org/apache/cassandra/cql3/CQLTester.java:
##########
@@ -680,6 +684,60 @@ public void cleanupCache()
store.cleanupCache();
}
+ public void snapshot(String snapshotName)
+ {
+ snapshot(snapshotName, null, now());
+ }
+
+ public void snapshot(String snapshotName, Instant creationTime)
+ {
+ snapshot(snapshotName, null, creationTime);
+ }
+
+ public void snapshot(String snapshotName, DurationSpec.IntSecondsBound ttl)
+ {
+ snapshot(snapshotName, false, ttl, null, now());
+ }
+
+ public void snapshot(String snapshotName, DurationSpec.IntSecondsBound
ttl, Instant creationTime)
+ {
+ snapshot(snapshotName, false, ttl, null, creationTime);
+ }
+
+ public void snapshot(String snapshotName, boolean ephemeral,
DurationSpec.IntSecondsBound ttl, Instant creationTime)
+ {
+ snapshot(snapshotName, ephemeral,false, ttl, null, creationTime);
+ }
+
+ public void snapshot(String snapshotName, boolean skipMemtable,
DurationSpec.IntSecondsBound ttl, RateLimiter rateLimiter, Instant creationTime)
+ {
+ snapshot(snapshotName, false, skipMemtable, ttl, rateLimiter,
creationTime);
+ }
+
+ public void snapshot(String snapshotName, boolean ephemeral, boolean
skipMemtable, DurationSpec.IntSecondsBound ttl, RateLimiter rateLimiter,
Instant creationTime)
+ {
+ ColumnFamilyStore store = getCurrentColumnFamilyStore();
+ if(store != null)
+ {
+ store.snapshot(snapshotName, null, ephemeral, skipMemtable, ttl,
rateLimiter, creationTime);
+ }
+ }
+
+ public void clearSnapshot(String keyspace)
Review Comment:
`clearSnapshotForKeyspace` is better, I would think that paramter for this
method is name of the snapshot, not name of keyspace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
