dcapwell commented on code in PR #2144:
URL: https://github.com/apache/cassandra/pull/2144#discussion_r1129779004
##########
src/java/org/apache/cassandra/service/accord/AccordService.java:
##########
@@ -240,6 +242,12 @@ private static RuntimeException throwTimeout(TxnId txnId,
Txn txn, ConsistencyLe
: new ReadTimeoutException(consistencyLevel, 0, 0,
false, txnId.toString());
}
+ private static RuntimeException throwPreempted(TxnId txnId, Txn txn,
ConsistencyLevel consistencyLevel)
+ {
+ throw txn.isWrite() ? new
WritePreemptedException(WriteType.TRANSACTION, consistencyLevel, 0, 0,
txnId.toString())
Review Comment:
when you rebase this will become a regression, can you use `CAS`? I
document why in CASSANDRA-18299; `TRANSACTION` requires driver/protocol changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
