dcapwell commented on code in PR #2144: URL: https://github.com/apache/cassandra/pull/2144#discussion_r1123959683
########## src/java/org/apache/cassandra/service/accord/AccordSafeState.java: ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.service.accord; + +import java.util.function.Function; + +import accord.impl.SafeState; +import accord.utils.async.AsyncChain; +import accord.utils.async.AsyncResults; +import org.apache.cassandra.service.accord.AccordLoadingState.LoadingState; + +public interface AccordSafeState<K, V> extends SafeState<V> +{ + void set(V update); + V original(); + void preExecute(); + void postExecute(); + AccordLoadingState<K, V> global(); + + default boolean hasUpdate() + { + return original() != current(); + } + + default void revert() + { + set(original()); + } + + default K key() + { + return global().key(); + } + + default LoadingState loadingState() + { + return global().state(); + } + + default AsyncResults.RunnableResult<V> load(Function<K, V> loadFunction) + { + return global().load(loadFunction); + } + + default AsyncChain<?> listen() + { + return global().listen(); + } + + default Throwable failure() + { + return global().failure(); + } + + default void checkNotInvalidated() + { + if (invalidated()) + throw new IllegalStateException("Cannot access invalidated " + this); Review Comment: `org.apache.cassandra.service.accord.async.AsyncOperation#runInternal` calls ``` commandStore.completeOperation(safeStore, context.commands, context.commandsForKeys); ``` which makes it unsafe for `writer` to have access to `org.apache.cassandra.service.accord.async.AsyncOperation.Context#commands` So, for this to work we need to do `completeOperation` *after* the write, or make the writer context not have access. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
