adelapena commented on code in PR #1891:
URL: https://github.com/apache/cassandra/pull/1891#discussion_r1134435571
##########
src/java/org/apache/cassandra/db/compaction/Scrubber.java:
##########
@@ -614,7 +619,84 @@ public Unfiltered next()
}
nextToOffer = null;
- return next;
+ return computeFinalRow((Row) next);
+ }
+
+ private Row computeFinalRow(Row next)
+ {
+ // If the row has overflowed let rows skip them unless we need to
keep them for the overflow policy
+ if (hasOverflowedLocalExpirationTimeRow((Row) next) &&
!reinsertOverflowedTTLRows)
+ return null;
+ else if (reinsertOverflowedTTLRows)
+ return rebuildTimestamptsForOverflowedRows(next);
+ else
+ return next;
+ }
+
+ /*
+ * When building ldt on deser it won't overflow now being a long as it
used to. This causes row resurrection for old sstable formats!
Review Comment:
Nit: split the long line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
