adelapena commented on code in PR #1891:
URL: https://github.com/apache/cassandra/pull/1891#discussion_r1135336943
##########
src/java/org/apache/cassandra/db/RangeTombstoneList.java:
##########
@@ -146,11 +153,16 @@ public void add(RangeTombstone tombstone)
* This method will be faster if the new tombstone sort after all the
currently existing ones (this is a common use case),
* but it doesn't assume it.
*/
- public void add(ClusteringBound<?> start, ClusteringBound<?> end, long
markedAt, int delTime)
+ public void add(ClusteringBound<?> start, ClusteringBound<?> end, long
markedAt, long delTime)
Review Comment:
I think the version taking `int delTimeUnsignedInteger` should be `private`.
The version taking `long delTime` is dead code without any test coverage, so it
should be deleted. AFAIK `RangeTombstoneList` is not a public API so there is
no reason to keep old unused methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
