maedhroz commented on code in PR #2195:
URL: https://github.com/apache/cassandra/pull/2195#discussion_r1134651853
##########
src/java/org/apache/cassandra/cql3/statements/BatchStatement.java:
##########
@@ -235,7 +261,7 @@ public void validate() throws InvalidRequestException
for (ModificationStatement stmt : statements)
{
if (ksName != null && (!stmt.keyspace().equals(ksName) ||
!stmt.table().equals(cfName)))
- throw new InvalidRequestException("Batch with conditions
cannot span multiple tables");
+ throw new InvalidRequestException("Batch with conditions
cannot span multiple tables: " + stmt.source.describe(true));
Review Comment:
Is there any coverage for these two cases in `BatchTest`? In general, feels
like it would be good to have a test for the `ModificationStatement` case...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
