maedhroz commented on code in PR #2195:
URL: https://github.com/apache/cassandra/pull/2195#discussion_r1138094108
##########
src/java/org/apache/cassandra/cql3/statements/TransactionStatement.java:
##########
@@ -366,21 +357,19 @@ public ResultMessage execute(QueryState state,
QueryOptions options, long queryS
try
{
+ // check again since now we have query options; note that
statements are quaranted to be single partition reads at this point
for (NamedSelect assignment : assignments)
- checkAtMostOneRowSpecified(state.getClientState(), options,
assignment.select, INCOMPLETE_PRIMARY_KEY_LET_MESSAGE);
+ checkFalse(isSelectingMultipleClusterings(assignment.select,
options), INCOMPLETE_PRIMARY_KEY_SELECT_MESSAGE, "LET assignment",
assignment.select.source);
if (returningSelect != null)
- checkAtMostOneRowSpecified(state.getClientState(), options,
returningSelect.select, INCOMPLETE_PRIMARY_KEY_SELECT_MESSAGE);
+
checkFalse(isSelectingMultipleClusterings(returningSelect.select, options),
INCOMPLETE_PRIMARY_KEY_SELECT_MESSAGE, "returning SELECT",
returningSelect.select.source);
Review Comment:
I'd even be fine if we just did what we do for INSERT/UPDATE...that is, just
say `SELECT at [2:1]` or `LET at [1:1]`. Not sure if someone reading this would
glean information from "returning" or it's just an implementation detail.
CC @dcapwell
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
