Mmuzaf commented on code in PR #2133:
URL: https://github.com/apache/cassandra/pull/2133#discussion_r1149856093
##########
src/java/org/apache/cassandra/service/StorageService.java:
##########
@@ -1536,7 +1540,6 @@ else if (tokens == null)
public void setRpcTimeout(long value)
{
DatabaseDescriptor.setRpcTimeout(value);
- logger.info("set rpc timeout to {} ms", value);
Review Comment:
I tend to agree here, but my concern here is that someone is doing something
wrong if someone relies on log messages.
The `ConfigurationRegistry` will log any changes to the property's values,
but the log message will look slightly different. Anyway, a user will still be
able to see it in the logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
