Mmuzaf commented on code in PR #2133:
URL: https://github.com/apache/cassandra/pull/2133#discussion_r1149857695
##########
src/java/org/apache/cassandra/service/StorageService.java:
##########
@@ -972,6 +974,8 @@ public void runMayThrow() throws InterruptedException,
ExecutionException, IOExc
logger.info("Not joining ring as requested. Use JMX
(StorageService->joinRing()) to initiate ring joining");
}
+ getConfigRegistry().addPropertyConstraint(REPAIR_REQUEST_TIMEOUT,
+
DurationSpec.LongMillisecondsBound.class, (newVal) ->
Preconditions.checkState(newVal.toMilliseconds() > 0));
Review Comment:
I agree with you - this is not the right place to have property constraints,
so we will move it to the validation subsystem once the discussion on the ML is
finished.
The reason why it exists is simple - the type
`DurationSpec.LongMillisecondsBound` itself provides only `<= 0` guarantees,
however, the property requires strickly `> 0`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
