jacek-lewandowski commented on code in PR #2046:
URL: https://github.com/apache/cassandra/pull/2046#discussion_r1158275488
##########
src/java/org/apache/cassandra/db/commitlog/CommitLogSegmentReader.java:
##########
@@ -50,8 +50,10 @@
*/
public class CommitLogSegmentReader implements
Iterable<CommitLogSegmentReader.SyncSegment>
{
- public static final String ALLOW_IGNORE_SYNC_CRC = Config.PROPERTY_PREFIX
+ "commitlog.allow_ignore_sync_crc";
- private static volatile boolean allowSkipSyncMarkerCrc =
Boolean.getBoolean(ALLOW_IGNORE_SYNC_CRC);
+ /** @deprecated Use {@link
org.apache.cassandra.config.CassandraRelevantProperties#COMMITLOG_ALLOW_IGNORE_SYNC_CRC}.
*/
Review Comment:
But it applies to an API - I don't think this is an API. On the other hand,
we have some property names defined in interfaces like the one for `Guardrails`
or `SchemaUpdateHandlerProvider` which are APIs.
We can also deprecate it in 4.1.x, just like with Hadoop, which was much
more significant deprecation and we decided to do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
