jacek-lewandowski commented on code in PR #2046: URL: https://github.com/apache/cassandra/pull/2046#discussion_r1158401387
########## src/java/org/apache/cassandra/config/CassandraRelevantProperties.java: ########## Review Comment: @Mmuzaf regarding defaults - I agree. What I mean was actually that we should **forbid** defaults in CRP in two cases: - this is not a Cassandra specific property - the rationale is that it can be misleading and hard to track - for example, imagine a netty property which is obviously defined in CRP. We have no idea what default the relevant component (like Netty) assumed. Moreover it may change with a new component version I doubt anybody will ever track that. In other words, non Cassandra-specific properties are defined in CRP to be set rather than read, so defaults for them are confusing. Maybe even reading from them should be forbidden? IDK - the default value is the default default value :D, like null, false, 0 I don't think you need more reviews. If you put each IDE-aided refactoring in a distinct commit, we will not have to go through all the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
