dcapwell commented on code in PR #2261:
URL: https://github.com/apache/cassandra/pull/2261#discussion_r1159223582


##########
src/java/org/apache/cassandra/gms/Gossiper.java:
##########
@@ -2141,6 +2141,11 @@ public void addLocalApplicationState(ApplicationState 
applicationState, Versione
         addLocalApplicationStates(Arrays.asList(Pair.create(applicationState, 
value)));
     }
 
+    public void addLocalApplicationState(ApplicationState state1, 
VersionedValue value1, ApplicationState state2, VersionedValue value2)

Review Comment:
   added this method as the locking is done at the call level, so when we have 
STATUS and STATUS_AND_PORT as 2 different calls we can get into a state where 
we gossip one changed and the other unchanged; by using this new method both 
status are updated in the same lock



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to