dcapwell commented on code in PR #2261:
URL: https://github.com/apache/cassandra/pull/2261#discussion_r1159224404
##########
src/java/org/apache/cassandra/locator/DynamicEndpointSnitch.java:
##########
@@ -224,6 +226,11 @@ private <C extends ReplicaCollection<? extends C>> C
sortedByProximityWithBadnes
return replicas;
}
+ private static double defaultStore(InetAddressAndPort target)
+ {
+ return USE_SEVERITY ? getSeverity(target) : 0.0;
Review Comment:
not sure if this change should also be behind a config flag... this is a
change in behavior if you set severity... this is done to make this patch work
in a stable manner, but outside of decom severity is used to limit traffic, yet
we had different code paths to ignore it (such as reset every 10m). By
defaulting to severity we always respect the operators intent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
