michaelsembwever commented on code in PR #2222: URL: https://github.com/apache/cassandra/pull/2222#discussion_r1159545289
########## conf/cassandra.yaml: ########## @@ -566,6 +566,14 @@ commitlog_segment_size: 32MiB # # flush_compression: fast +# Defines the compression params used to read/write the sstables. If undefined the default is LZ4 with 16kb chunk +# length and min_compress_ratio of 0.0 (see CompressionParams.DEFAULT_MIN_COMPRESS_RATIO). +# This is the default options for sstable compression, the (schema) table-level settings will override this option. +#sstable_compressor: +# class: "org.apache.cassandra.io.compress.LZ4Compressor" Review Comment: what's the harm is providing aliases to the simple class names ? I see benefit and simplicity in permitting the user to define any of the following (to the same effect) ``` class_name: "lz4" class_name: "LZ4Compressor" class_name: "org.apache.cassandra.io.compress.LZ4Compressor" ``` (note, `class_name` is the standard in the yaml) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
