smiklosovic commented on code in PR #2222:
URL: https://github.com/apache/cassandra/pull/2222#discussion_r1159560204
##########
conf/cassandra.yaml:
##########
@@ -566,6 +566,14 @@ commitlog_segment_size: 32MiB
#
# flush_compression: fast
+# Defines the compression params used to read/write the sstables. If
undefined the default is LZ4 with 16kb chunk
+# length and min_compress_ratio of 0.0 (see
CompressionParams.DEFAULT_MIN_COMPRESS_RATIO).
+# This is the default options for sstable compression, the (schema)
table-level settings will override this option.
+#sstable_compressor:
+# class: "org.apache.cassandra.io.compress.LZ4Compressor"
+# chunk_length_in_kb: "16"
+# min_compress_ratio: "0"
Review Comment:
Yeah, so `class_name`. ParameterizedClass has it everywhere like
`class_name` if I am not mistaken. Properties for compressor would be
"parameters"
public class ParameterizedClass
{
public static final String CLASS_NAME = "class_name";
public static final String PARAMETERS = "parameters";
public String class_name;
public Map<String, String> parameters;
public ParameterizedClass()
{
// for snakeyaml
}
I think it is better to follow yaml naming (class_name and parameters) and
then parameters would have keys and values as in CQL to have it generic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
