dcapwell commented on code in PR #40:
URL: https://github.com/apache/cassandra-accord/pull/40#discussion_r1160925222
##########
accord-core/src/main/java/accord/messages/Defer.java:
##########
@@ -80,7 +80,7 @@ public void onChange(SafeCommandStore safeStore, SafeCommand
safeCommand)
int id = safeStore.commandStore().id();
if (!waitingOn.contains(id))
- throw new IllegalStateException();
+ throw new IllegalStateException("Not waiting on CommandStore " +
id);
Review Comment:
this is from https://issues.apache.org/jira/browse/CASSANDRA-18364, I hit in
burn test so patched here to get stable
##########
accord-core/src/main/java/accord/messages/Commit.java:
##########
@@ -162,7 +162,8 @@ public synchronized ReadNack apply(SafeCommandStore
safeStore)
case Insufficient:
SafeCommand safeCommand = safeStore.command(txnId);
Invariants.checkState(!safeCommand.current().known().isDefinitionKnown());
- if (defer == null)
+ // When isDone=true this.process() is called and all
CommandStores run apply again; so safe to create a new one
Review Comment:
this is from https://issues.apache.org/jira/browse/CASSANDRA-18364, I hit in
burn test so patched here to get stable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
