dcapwell commented on code in PR #40:
URL: https://github.com/apache/cassandra-accord/pull/40#discussion_r1160983277
##########
accord-core/src/main/java/accord/messages/ReadData.java:
##########
@@ -251,9 +314,9 @@ private void read(SafeCommandStore safeStore,
Command.Committed command)
void obsolete()
{
- if (!isObsolete)
+ if (state == State.PENDING)
Review Comment:
if its `RETURNED` then that's fine, it just means that the txn was
invalidated or applied after the fact.
If its OBSOLETE that just means another store set it
so both cases should be fine to ignore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
