iamaleksey commented on PR #2256: URL: https://github.com/apache/cassandra/pull/2256#issuecomment-1503424458
> trying to figure out what's going on here, but touching the journal failed when using C* > > ``` > ERROR [AccordJournal-allocator] 2023-04-06 14:38:46,445 Journal.java:617 - Failed allocating journal segments. Journal AccordJournal failure policy is STOP; terminating thread. > java.lang.NoClassDefFoundError: org/apache/commons/collections/set/UnmodifiableSet > at org.apache.cassandra.journal.Metadata.<init>(Metadata.java:63) > at org.apache.cassandra.journal.Metadata.create(Metadata.java:55) > at org.apache.cassandra.journal.ActiveSegment.create(ActiveSegment.java:85) > at org.apache.cassandra.journal.Journal.createSegment(Journal.java:452) > at org.apache.cassandra.journal.Journal.access$200(Journal.java:77) > at org.apache.cassandra.journal.Journal$AllocateRunnable.runNormal(Journal.java:394) > at org.apache.cassandra.journal.Journal$AllocateRunnable.run(Journal.java:376) > at org.apache.cassandra.concurrent.InfiniteLoopExecutor.loop(InfiniteLoopExecutor.java:121) > at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) > at java.base/java.lang.Thread.run(Thread.java:829) > Caused by: java.lang.ClassNotFoundException: org.apache.commons.collections.set.UnmodifiableSet > at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:581) > at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178) > at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522) > ... 10 common frames omitted > ``` > > This is from commons-collection-3.2.1, which is there from build > > ``` > $ ls build/lib/jars/commons-collections-3.2.1.jar > build/lib/jars/commons-collections-3.2.1.jar > ``` > > build not at runtime > > ``` > $ ls lib/commons-* > lib/commons-cli-1.1.jar lib/commons-codec-1.9.jar lib/commons-lang3-3.11.jar lib/commons-math3-3.2.jar > ``` > > Asking maven it looks like this is pulled in from Hadoop; which I thought was already removed > > ``` > $ mvn dependency:tree -f build/apache-cassandra-5.0-SNAPSHOT.pom > ... > [INFO] +- org.apache.hadoop:hadoop-core:jar:1.0.3:provided > [INFO] | +- xmlenc:xmlenc:jar:0.52:provided > [INFO] | +- commons-httpclient:commons-httpclient:jar:3.0.1:provided > [INFO] | +- org.apache.commons:commons-math:jar:2.1:provided > [INFO] | +- commons-configuration:commons-configuration:jar:1.6:provided > [INFO] | | +- commons-collections:commons-collections:jar:3.2.1:provided > ... > ``` Committed a fix to use `Collections.unmodifiableSet()` instead. (This was a somewhat recent change, not properly tested manually, but since commons is available in test, did in test). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
