maedhroz commented on code in PR #2253: URL: https://github.com/apache/cassandra/pull/2253#discussion_r1163056817
########## conf/cassandra.yaml: ########## @@ -1362,6 +1362,11 @@ server_encryption_options: # Set to a valid keystore if internode_encryption is dc, rack or all keystore: conf/.keystore keystore_password: cassandra Review Comment: Looking at this one last time, don't we want to comment out all 4 of the `keystore_password` and `truststore_password` field in the YAML? If we leave them there, and operators just start using the YAML we ship, we will essentially have preserved the "cassandra" default. The point of all this is that we want to force the operator to choose passwords, right? CC @smiklosovic -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
