smiklosovic commented on code in PR #2253: URL: https://github.com/apache/cassandra/pull/2253#discussion_r1165180776
########## conf/cassandra.yaml: ########## @@ -1362,6 +1362,11 @@ server_encryption_options: # Set to a valid keystore if internode_encryption is dc, rack or all keystore: conf/.keystore keystore_password: cassandra Review Comment: Aha, this is great catch. Yes we should not have them explicitly written there. Just comment it out and leave "cassandra" as password there to have some hint what to put there so people have easy job. "cassandra" password is used sometimes during testing etc, some testing clusters just have "cassandra" password for their certs / keys, same as they have "cassandra" password by default for CQL when using PasswordAuthenticator. If somebody is going to uncomment a password which has "cassandra" as default, it will be explicitly obvious to him and maybe people will think twice if it is a good idea to have a password like that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
