jacek-lewandowski commented on code in PR #2046:
URL: https://github.com/apache/cassandra/pull/2046#discussion_r1166868631
##########
test/unit/org/apache/cassandra/config/DatabaseDescriptorTest.java:
##########
@@ -233,11 +235,9 @@ public void testInvalidPartition() throws Exception
@Test
public void testInvalidPartitionPropertyOverride() throws Exception
{
- String key = Config.PROPERTY_PREFIX + "partitioner";
- String previous = System.getProperty(key);
+ String previous =
CassandraRelevantProperties.PARTITIONER.setString("ThisDoesNotExist");
Review Comment:
ok, create a separate ticket please
##########
src/java/org/apache/cassandra/config/CassandraRelevantProperties.java:
##########
@@ -588,6 +817,21 @@ public void setEnum(Enum<?> value) {
System.setProperty(key, value.name());
}
+ /**
+ * @param key Property string key..
+ * @return Property.
+ */
+ public static CassandraRelevantProperties getProperty(String key)
Review Comment:
aww, this seems to be slow - in the static initializer you already create a
set to verify uniqueness of keys - why don't you just create a hash map
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
