dcapwell commented on code in PR #2295:
URL: https://github.com/apache/cassandra/pull/2295#discussion_r1176844453
##########
src/java/org/apache/cassandra/config/Config.java:
##########
@@ -359,9 +352,14 @@ public MemtableOptions()
public String[] data_file_directories = new String[0];
- public List<ParameterizedClass> sstable_formats = ImmutableList.of(new
ParameterizedClass(BigFormat.class.getName(),//
"org.apache.cassandra.io.sstable.format.big.BigFormat",
-
ImmutableMap.of(SSTABLE_FORMAT_ID, "0",
-
SSTABLE_FORMAT_NAME, "big")));
+ public static class SSTableFormats
+ {
+ public String selected_format;
+ public String selected_version;
Review Comment:
my thinking is, if we do want to later (not this patch) allow overriding via
JMX or Settings table, how can you do thing safely?
Lets say we have the following cases
1) keep same format, just change version (use case; major/minor upgrade
wants to delay using latest until "stable")
```
sstable_formats.selected_version = next // this is "safe"
```
2) switch from big to bti or some 3rd party format
```
sstable_formats.selected_version = bti_version // unsafe, breaks BIG
sstable_formats.selected_format = bti
```
or
```
sstable_formats.selected_format = bti // unsafe as "selected_version" still
points to BIG version
sstable_formats.selected_version = bti_version
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
