jacek-lewandowski commented on code in PR #2295:
URL: https://github.com/apache/cassandra/pull/2295#discussion_r1177450616
##########
src/java/org/apache/cassandra/io/sstable/format/SSTableFormat.java:
##########
@@ -113,99 +114,85 @@ IScrubber getScrubber(ColumnFamilyStore cfs,
void deleteOrphanedComponents(Descriptor descriptor, Set<Component>
components);
- void setup(int id, String name, Map<String, String> options);
-
- Type getType();
-
/**
* Deletes the existing components of the sstables represented by the
provided descriptor.
* The method is also responsible for cleaning up the in-memory resources
occupied by the stuff related to that
* sstables, such as row key cache entries.
*/
void delete(Descriptor descriptor);
+ /**
+ * This class is not completely redundant
Review Comment:
Did I really write "not"??? 🤦🏻♂️ I wanted to write it is redundant and
that's why I marked it deprecated. That "not" is a typing mistake.
The only reason I haven't removed it is that the additional changeset would
be quite large. So if we agree on that, we can do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
