belliottsmith commented on code in PR #38:
URL: https://github.com/apache/cassandra-accord/pull/38#discussion_r1178851913
##########
accord-core/src/main/java/accord/local/CommandStore.java:
##########
@@ -43,16 +45,113 @@ CommandStore create(int id,
RangesForEpochHolder rangesForEpoch);
}
- int id();
- Agent agent();
- AsyncChain<Void> execute(PreLoadContext context, Consumer<? super
SafeCommandStore> consumer);
- <T> AsyncChain<T> submit(PreLoadContext context, Function<? super
SafeCommandStore, T> apply);
+ @Nullable
+ public static CommandStore maybeCurrent()
Review Comment:
[Preference]: I would prefer not to clutter the preamble with these methods,
and would stick them at the bottom of the class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
