dcapwell commented on code in PR #2299:
URL: https://github.com/apache/cassandra/pull/2299#discussion_r1179737237
##########
src/java/org/apache/cassandra/utils/SyncUtil.java:
##########
@@ -99,6 +101,12 @@
public static MappedByteBuffer force(MappedByteBuffer buf)
{
Preconditions.checkNotNull(buf);
+ Object attachment = MemoryUtil.getAttachment(buf);
+ if (attachment instanceof Runnable)
Review Comment:
the `FileSystem` runs in app `ClassLoader` but this logic runs in
`InstanceClassLoader`, so I can't use a non standard type here...
This is a field access, but if there are concerns about this I can always
make this a test flag, so we only enter this if a static field is set to true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
