dcapwell commented on code in PR #2299:
URL: https://github.com/apache/cassandra/pull/2299#discussion_r1179740042
##########
test/simulator/main/org/apache/cassandra/simulator/ClusterSimulation.java:
##########
@@ -683,9 +688,10 @@ public ClusterSimulation(RandomSource random, long seed,
int uniqueNum,
.set("memtable_allocation_type",
builder.memoryListener != null ? "unslabbed_heap_buffers_logged" :
"heap_buffers")
.set("file_cache_size", "16MiB")
.set("use_deterministic_table_id", true)
- .set("disk_access_mode", "standard")
+// .set("disk_access_mode", "standard")
Review Comment:
wondering if it would be good to have these configs based off the
`RandomSource`? that way we test all code paths rather than specific ones?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
