dcapwell commented on code in PR #2295:
URL: https://github.com/apache/cassandra/pull/2295#discussion_r1185509005
##########
src/java/org/apache/cassandra/db/lifecycle/LogFile.java:
##########
@@ -504,7 +507,7 @@ List<String> getFilePaths()
private String getFileName()
{
- return
StringUtils.join(SSTableFormat.Type.current().info.getLatestVersion(),
LogFile.SEP, // remove version and separator when downgrading to 4.x is becomes
unsupported
+ return StringUtils.join(version, LogFile.SEP, // remove version and
separator when downgrading to 4.x is becomes unsupported TODO should this
include format type as well?
Review Comment:
> TODO should this include format type as well?
if the version does not include the format, I think it would be good... `nc`
isn't useful as I don't know this is `big` or `bti`
Another option is to use `version.toFormatAndVersionString`?
##########
conf/cassandra.yaml:
##########
@@ -1928,14 +1928,5 @@ drop_compact_storage_enabled: false
# excluded_keyspaces: # comma separated list of keyspaces to exclude from
the check
# excluded_tables: # comma separated list of keyspace.table pairs to
exclude from the check
-# Supported sstable formats
-# This is a list of elements consisting of class_name and parameters, where
class_name should point to the class
-# implementing org.apache.cassandra.io.sstable.format.SSTableFormat.
Parameters must include unique 'id' integer
-# which is used in some serialization to denote the format type in a compact
way (such as local key cache); and 'name'
-# which will be used to recognize the format type - in particular that name
will be used in sstable file names and in
-# stream headers so the name has to be the same for the same format across all
the nodes in the cluster.
-sstable_formats:
- - class_name: org.apache.cassandra.io.sstable.format.big.BigFormat
- parameters:
- id: 0
- name: big
+#sstable_formats:
Review Comment:
can you update the yaml to match the `Config` change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
