dcapwell commented on code in PR #2295:
URL: https://github.com/apache/cassandra/pull/2295#discussion_r1178240194
##########
src/java/org/apache/cassandra/cache/AutoSavingCache.java:
##########
@@ -196,12 +205,18 @@ public int loadSaved()
// modern format, allows both key and value (so key cache load can be
purely sequential)
File dataPath = getCacheDataPath(CURRENT_VERSION);
File crcPath = getCacheCrcPath(CURRENT_VERSION);
- if (dataPath.exists() && crcPath.exists())
+ File metadataPath = getCacheMetadataPath(CURRENT_VERSION);
+ if (dataPath.exists() && crcPath.exists() && metadataPath.exists())
Review Comment:
Given that this change already landed, I don't mind this being punted from
this PR, but would be good to ask in dev@? This would be a performance issue
during major upgrades but once warm you stop seeing it...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
