belliottsmith commented on code in PR #45:
URL: https://github.com/apache/cassandra-accord/pull/45#discussion_r1185538852
##########
accord-core/src/main/java/accord/local/CommandStore.java:
##########
@@ -83,6 +123,65 @@ public Agent agent()
public abstract void shutdown();
+ // implementations are expected to override this for persistence
+ protected void setRejectBefore(ReducingRangeMap<Timestamp> newRejectBefore)
+ {
Review Comment:
I can introduce an additional method, perhaps, though we probably need to
think this through when we integrate anyway so it probably doesn't help much
yet. But, to explain my thinking here: all of the implementation details are
kept within Accord so that the implementation cannot mess with it (though of
course it must invoke `super`). I don't really want the implementation
controlling the data structure itself, just to have the ability to persist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
