belliottsmith commented on code in PR #45:
URL: https://github.com/apache/cassandra-accord/pull/45#discussion_r1185540664
##########
accord-core/src/main/java/accord/primitives/TxnId.java:
##########
@@ -120,7 +128,7 @@ private static Domain domain(int flags)
private static int rwOrdinal(int flags)
{
- return (flags >> 1) & 1;
+ return (flags >> 1) & 7;
Review Comment:
We have a bunch of `Kind`, but I agree `rw` is now bad terminology. I'll
ponder what alternatives there might be, and same for the name within Txn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
