belliottsmith commented on code in PR #45:
URL: https://github.com/apache/cassandra-accord/pull/45#discussion_r1188318733
##########
accord-core/src/main/java/accord/local/CommandStore.java:
##########
@@ -83,6 +123,69 @@ public Agent agent()
public abstract void shutdown();
+ // implementations are expected to override this for persistence
+ protected void setRejectBefore(ReducingRangeMap<Timestamp> newRejectBefore)
+ {
+ this.rejectBefore = newRejectBefore;
+ }
+
+ /**
+ * To be overridden by implementations, to ensure the new state is
persisted
+ *
+ * TODO (required): consider handling asynchronicity of persistence
+ * (could leave to impls to call this parent method once persisted)
+ * TODO (desired): compact Ranges, merging overlaps
+ */
+ protected void setBootstrapBeganAt(NavigableMap<TxnId, Ranges>
newBootstrapBeganAt)
+ {
+ this.bootstrapBeganAt = newBootstrapBeganAt;
+ }
+
+ protected abstract void registerHistoricalTransactions(Deps deps);
+<<<<<<< Updated upstream
+=======
+ protected abstract void evictLog(TxnId txnIdBefore);
+>>>>>>> Stashed changes
Review Comment:
Oh, whoops that seems to have peeked into the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
