jakubzytka commented on code in PR #2336:
URL: https://github.com/apache/cassandra/pull/2336#discussion_r1193982764
##########
test/distributed/org/apache/cassandra/distributed/upgrade/MixedModeAvailabilityTestBase.java:
##########
@@ -46,51 +46,46 @@
public abstract class MixedModeAvailabilityTestBase extends UpgradeTestBase
{
+ /**
+ * this test only supports valid upgrade paths that start no
+ * earlier than v3
+ */
+ private static final Semver MINIMAL_APPLICABLE_VERSION = v30;
private static final int NUM_NODES = 3;
private static final int COORDINATOR = 1;
private static final String INSERT = withKeyspace("INSERT INTO %s.t (k, c,
v) VALUES (?, ?, ?)");
private static final String SELECT = withKeyspace("SELECT * FROM %s.t
WHERE k = ?");
- private final Semver initial;
private final ConsistencyLevel writeConsistencyLevel;
private final ConsistencyLevel readConsistencyLevel;
- public MixedModeAvailabilityTestBase(Semver initial, ConsistencyLevel
writeConsistencyLevel, ConsistencyLevel readConsistencyLevel)
+ public MixedModeAvailabilityTestBase(ConsistencyLevel
writeConsistencyLevel, ConsistencyLevel readConsistencyLevel)
{
- this.initial = initial;
this.writeConsistencyLevel = writeConsistencyLevel;
this.readConsistencyLevel = readConsistencyLevel;
}
@Test
public void testAvailabilityCoordinatorNotUpgraded() throws Throwable
{
- testAvailability(false, initial, writeConsistencyLevel,
readConsistencyLevel);
+ testAvailability(false, MINIMAL_APPLICABLE_VERSION,
writeConsistencyLevel, readConsistencyLevel);
}
@Test
public void testAvailabilityCoordinatorUpgraded() throws Throwable
{
- testAvailability(true, initial, writeConsistencyLevel,
readConsistencyLevel);
- }
-
- protected static void testAvailability(Semver initial,
Review Comment:
this was unused
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
