jakubzytka commented on code in PR #2336:
URL: https://github.com/apache/cassandra/pull/2336#discussion_r1193985610
##########
test/distributed/org/apache/cassandra/distributed/upgrade/MixedModeConsistencyTest.java:
##########
@@ -38,9 +38,10 @@
import static org.apache.cassandra.distributed.shared.AssertUtils.assertRows;
import static org.apache.cassandra.distributed.shared.AssertUtils.row;
-public class MixedModeConsistencyTestBase extends UpgradeTestBase
+public class MixedModeConsistencyTest extends UpgradeTestBase
{
- protected static void testConsistency(Semver initial) throws Throwable
+ @Test
+ public void testConsistency() throws Throwable
Review Comment:
there used to be a single subclass for `v30`. I removed it and just inlined
`v30`.
I don't see value in a separate class (unless we care for butler history)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
