dcapwell commented on code in PR #2310:
URL: https://github.com/apache/cassandra/pull/2310#discussion_r1194062013
##########
test/unit/org/apache/cassandra/cql3/CQLTester.java:
##########
@@ -1564,13 +1569,24 @@ public static void assertRows(UntypedResultSet result,
Object[]... rows)
{
Object actualValueDecoded = actualValue == null ? null :
column.type.getSerializer().deserialize(actualValue);
if (!Objects.equal(expected != null ? expected[j] : null,
actualValueDecoded))
+ {
+ //TODO confirm this isn't a bug...
Review Comment:
why is this? At least in IntelliJ `//TODO` causes the comments under this
to be flagged as part of the TODO, which is true for this case... If I switch
to `// TODO` that goes away and only this line is flagged... Not actually sure
that this is a feature in IntelliJ... I just noticed when I made this change...
I don't think we have a style guide comment for this, so prefer to keep
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
