dcapwell commented on code in PR #2310:
URL: https://github.com/apache/cassandra/pull/2310#discussion_r1194101268
##########
src/java/org/apache/cassandra/db/marshal/PartitionerDefinedOrder.java:
##########
@@ -130,6 +130,12 @@ public void validate(ByteBuffer bytes) throws
MarshalException
throw new IllegalStateException("You shouldn't be validating this.");
}
+ @Override
+ public <V> boolean isNull(V buffer, ValueAccessor<V> accessor)
Review Comment:
NOTE: `text` and `byte[]` treat the empty set as non-null, so this class
will convert those to `null`... I didn't want to really go down the rabbit hole
to figure out the impact to this... but this isn't "correct" from the types
point of view...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
