frankgh commented on code in PR #45: URL: https://github.com/apache/cassandra-sidecar/pull/45#discussion_r1194426923
########## src/main/java/org/apache/cassandra/sidecar/routes/sstableuploads/SSTableCleanupHandler.java: ########## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.sidecar.routes.sstableuploads; + +import java.nio.file.NoSuchFileException; + +import com.google.inject.Inject; +import io.netty.handler.codec.http.HttpResponseStatus; +import io.vertx.core.http.HttpMethod; +import io.vertx.core.http.HttpServerRequest; +import io.vertx.core.net.SocketAddress; +import io.vertx.ext.web.RoutingContext; +import org.apache.cassandra.sidecar.concurrent.ExecutorPools; +import org.apache.cassandra.sidecar.routes.AbstractHandler; +import org.apache.cassandra.sidecar.utils.InstanceMetadataFetcher; +import org.apache.cassandra.sidecar.utils.SSTableUploadsPathBuilder; + +import static org.apache.cassandra.sidecar.utils.HttpExceptions.wrapHttpException; + +/** + * Manages cleaning up uploaded SSTables + */ +public class SSTableCleanupHandler extends AbstractHandler<String> +{ + private static final String UPLOAD_ID_PARAM = "uploadId"; + private final SSTableUploadsPathBuilder uploadPathBuilder; + + /** + * Constructs a handler with the provided {@code metadataFetcher} + * + * @param metadataFetcher the instance metadata fetcher + * @param uploadPathBuilder a class that provides SSTableUploads directories + * @param executorPools executor pools for blocking executions + */ + @Inject + protected SSTableCleanupHandler(InstanceMetadataFetcher metadataFetcher, + SSTableUploadsPathBuilder uploadPathBuilder, + ExecutorPools executorPools) + { + super(metadataFetcher, executorPools, null); + this.uploadPathBuilder = uploadPathBuilder; + } + + /** + * Handles cleaning up the SSTable upload staging directory + * + * @param context the context for the handler + */ + @Override + public void handleInternal(RoutingContext context, + HttpServerRequest httpRequest, + String host, + SocketAddress remoteAddress, + String uploadId) + { + if (context.request().method() != HttpMethod.DELETE) + { + context.fail(wrapHttpException(HttpResponseStatus.BAD_REQUEST, "Unknown API requested")); + return; + } Review Comment: oh interesting. that should not be there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
