yifan-c commented on code in PR #45:
URL: https://github.com/apache/cassandra-sidecar/pull/45#discussion_r1194355882
##########
common/src/test/java/org/apache/cassandra/sidecar/common/SimpleCassandraVersionProviderTest.java:
##########
@@ -78,7 +78,7 @@ void ensureOutOfOrderInsertionWorks()
.add(new V41())
.add(new V30()).build();
- ICassandraFactory cassandra =
provider.getCassandra(SimpleCassandraVersion.create("4.0.0"));
+ ICassandraFactory cassandra =
provider.cassandra(SimpleCassandraVersion.create("4.0.0"));
assertThat(cassandra).hasSameClassAs(new V40());
Review Comment:
~To test `ensureOutOfOrderInsertionWorks`, should it get V30 from version
`SimpleCassandraVersion.create("3.0.0")`?~
~After I made the change, it actually fails, meaning the insertion order has
to be in the ascending order of the versions. Either updating the test case or
the implementation of builder is needed.~
It is unrelated with this patch, please ignore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
