dcapwell commented on code in PR #2339:
URL: https://github.com/apache/cassandra/pull/2339#discussion_r1203115912
##########
src/java/org/apache/cassandra/dht/Token.java:
##########
@@ -41,6 +42,16 @@ public abstract class Token implements RingPosition<Token>,
Serializable
public abstract ByteBuffer toByteArray(Token token);
public abstract Token fromByteArray(ByteBuffer bytes);
+ public byte[] toOrderedByteArray(Token token, ByteComparable.Version
version)
+ {
+ return ByteSourceInverse.readBytes(asComparableBytes(token,
version));
+ }
+
+ public Token fromOrderedByteArray(byte[] bytes, ByteComparable.Version
version)
Review Comment:
unused, but I like to make sure the to/from are both there... I know our
style guide says not to add dead code... but I felt its still best to have
to/from APIs go together
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
