dcapwell commented on code in PR #2339:
URL: https://github.com/apache/cassandra/pull/2339#discussion_r1203169761
##########
src/java/org/apache/cassandra/service/accord/AccordSafeCommandStore.java:
##########
@@ -174,19 +187,34 @@ private <O> O mapReduceForKey(Routables<?, ?>
keysOrRanges, Ranges slice, BiFunc
if (accumulate.equals(terminalValue))
return accumulate;
}
- break;
+ }
+ break;
case Range:
- // TODO (required): implement
- throw new UnsupportedOperationException();
+ {
+ // TODO (correctness): if a range is used, then the range must
exist in the PreLoadContext, else the commandsForKeys won't be in-sync... can
this be detected?
Review Comment:
added defensive check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
