bereng commented on code in PR #1891:
URL: https://github.com/apache/cassandra/pull/1891#discussion_r1203530498


##########
.circleci/config_template.yml:
##########
@@ -257,6 +257,10 @@ j8_separate_jobs: &j8_separate_jobs
         requires:
           - start_j8_unit_tests
           - j8_build
+    - j8_unit_tests-oa:

Review Comment:
   I was going to look into this and then decided everything is too nosy and 
cluttered already. We should use `REPEATED_ANT_TEST_TARGET` for all these 
variations imo.
   
   At the beginning that was nice sugar-coating but now it's growing and it 
will only get bigger imo. Circle config files are painful enough. I would leave 
it as it is and open a ticket to drop all specialized ant based repeats, use 
the generic ant repeat instead and document it properly :shrug: That should pay 
itself over time with the shortened config files. Wdyt?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to