bereng commented on code in PR #1891:
URL: https://github.com/apache/cassandra/pull/1891#discussion_r1188439080
##########
.circleci/config_template.yml:
##########
@@ -257,6 +257,10 @@ j8_separate_jobs: &j8_separate_jobs
requires:
- start_j8_unit_tests
- j8_build
+ - j8_unit_tests-oa:
Review Comment:
First I want to get your +1 on the approach of the feature flag and overall
approach. Then we ping Benedict.
If we're +1 then a rebase is needed which will bring jdk17 and other circle
changes where I will add all those oa changes, yes, but after the rebase. They
are extremely painful and I don't want to do them unless I have a +1 on the
rest from you both.
So wdyt, besides the circle loose ends, are you +1 here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
