5 commented on code in PR #47:
URL: https://github.com/apache/cassandra-sidecar/pull/47#discussion_r1213672197
##########
common/src/main/java/org/apache/cassandra/sidecar/common/NodeSettings.java:
##########
@@ -16,33 +16,82 @@
* limitations under the License.
*/
-
package org.apache.cassandra.sidecar.common;
+import java.io.ByteArrayOutputStream;
+import java.io.InputStream;
+import java.nio.charset.StandardCharsets;
import java.util.Objects;
import com.fasterxml.jackson.annotation.JsonProperty;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
/**
* Holds information about the specific node settings
*/
public class NodeSettings
{
- private final String releaseVersion;
+ private static final Logger LOGGER =
LoggerFactory.getLogger(NodeSettings.class);
+ private static final String SIDECAR_VERSION = getSidecarVersion();
+
private final String partitioner;
+ private final String releaseVersion;
+ private final String sidecarVersion;
+
+ private static String getSidecarVersion()
+ {
+ try (InputStream input =
NodeSettings.class.getResourceAsStream("/sidecar.version");
Review Comment:
I don't think having a constant here will help, as it cannot be referenced
from the Gradle build file… Local variable, maybe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
