5 commented on code in PR #47:
URL: https://github.com/apache/cassandra-sidecar/pull/47#discussion_r1218689783
##########
common/src/main/java/org/apache/cassandra/sidecar/common/NodeSettings.java:
##########
@@ -16,33 +16,80 @@
* limitations under the License.
*/
-
package org.apache.cassandra.sidecar.common;
+import java.io.ByteArrayOutputStream;
+import java.io.InputStream;
+import java.nio.charset.StandardCharsets;
+import java.util.Collections;
+import java.util.Map;
import java.util.Objects;
import com.fasterxml.jackson.annotation.JsonProperty;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
/**
* Holds information about the specific node settings
*/
public class NodeSettings
{
+ private static final Logger LOGGER =
LoggerFactory.getLogger(NodeSettings.class);
+ private static final String VERSION = "version";
+ private static final Map<String, String> SIDECAR =
Collections.singletonMap(VERSION, getSidecarVersion());
Review Comment:
In this specific case it was reading from an internal resource, and
swallowing all possible exceptions, but I agree that this can lead to issues
that are difficult to identify. Added a separate commit that uses Guice to
retrieve current Sidecar version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
