5 commented on code in PR #47: URL: https://github.com/apache/cassandra-sidecar/pull/47#discussion_r1219979953
########## common/src/main/java/org/apache/cassandra/sidecar/common/NodeSettings.java: ########## @@ -57,23 +82,41 @@ public String partitioner() return partitioner; } + @JsonProperty("sidecar") + public Map<String, String> sidecar() + { + return sidecar; + } + + public String sidecarVersion() + { + return sidecar.get(VERSION); + } + /** * {@inheritDoc} */ - public boolean equals(Object o) + public boolean equals(Object other) Review Comment: Acknowledged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org