maedhroz commented on code in PR #2409:
URL: https://github.com/apache/cassandra/pull/2409#discussion_r1228528948


##########
src/java/org/apache/cassandra/index/sai/disk/v1/MemtableIndexWriter.java:
##########
@@ -110,7 +112,7 @@ public void complete(Stopwatch stopwatch) throws IOException
 
             try (MemtableTermsIterator terms = new 
MemtableTermsIterator(memtable.getMinTerm(), memtable.getMaxTerm(), iterator))
             {
-                long cellCount = flush(minKey, maxKey, 
indexContext.getValidator(), terms);
+                long cellCount = flush(minKey, maxKey, 
indexContext.getValidator(), terms, rowMapping.maxSSTableRowId);

Review Comment:
   Just to clarify, we pass `maxSSTableRowId` here, but the argument we accept 
is `maxSegmentRowId`, because we're writing a single segment anyway?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to