maedhroz commented on code in PR #2409: URL: https://github.com/apache/cassandra/pull/2409#discussion_r1228651050
########## src/java/org/apache/cassandra/index/sai/disk/v1/bbtree/IntersectingPointValues.java: ########## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.cassandra.index.sai.disk.v1.bbtree; + +import java.io.IOException; + +import org.apache.lucene.codecs.MutablePointValues; +import org.apache.lucene.index.PointValues; +import org.apache.lucene.util.BytesRef; + +public abstract class IntersectingPointValues extends MutablePointValues +{ + private static final byte[] EMPTY = new byte[0]; + + public boolean needsSorting() + { + return size() > 1; + } + + public abstract void intersect(IntersectVisitor visitor) throws IOException; + + @Override + public int getDocCount() + { + throw new UnsupportedOperationException(); + } + + @Override + public long size() + { + return 1; + } + + @Override + public void getValue(int i, BytesRef packedValue) + { + // no-op + } + + @Override + public byte getByteAt(int i, int k) + { + return 0; + } + + @Override + public int getDocID(int i) + { + return 0; + } + + @Override + public void swap(int i, int j) + { + throw new IllegalStateException("unexpected sorting"); + } + + @Override + public void intersect(PointValues.IntersectVisitor visitor) + { + throw new UnsupportedOperationException(); + } + + @Override + public long estimatePointCount(PointValues.IntersectVisitor visitor) + { + throw new UnsupportedOperationException(); + } + + @Override + public byte[] getMinPackedValue() + { + return EMPTY; + } + + @Override + public byte[] getMaxPackedValue() + { + return EMPTY; + } + + @Override + public int getNumDimensions() + { + return 1; + } + + @Override + public int getBytesPerDimension() + { + return 0; + } Review Comment: Make this abstract? ``` public abstract int getBytesPerDimension(); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
